update issue template #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update issue template to include start and end dates for conference update conferences to use gh-issues instead of manual parsing update conferences template to use grid and new json methods add conferences.json remove envrc
update issue template to include start and end dates for conference update conferences to use gh-issues instead of manual parsing update conferences template to use grid and new json methods add conferences.json
Address the case where the conference url scheme is a valid protocol (such as ftp, http, ssh), but is not "https". We replace the existing scheme with the one we want
Add another test case
|
@dragid10 - can you pull the changes in via rebase to get only your changes. |
Yep did it! |
kjaymiller
requested changes
Oct 6, 2024
Co-authored-by: Jay Miller <[email protected]>
kjaymiller
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗: #504
Issue: #504
Type of Change
Description 📋
What: Fix url parser to handle urls with incorrect schemes.
E.g.
ftp://pycon.usis an invalid URL, but the url won't currently be replaced withhttps. This PR fixes thatWhy: This change allows us to have valid conference URLs
How: These changes should just fix more invalid URLs
Checklist ✅
pre-commit run --all